bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page URL: https://github.com/apache/hbase/pull/808#discussion_r344282323
########## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/HBaseThriftTestingUtility.java ########## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.thrift; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseTestingUtility; +import org.apache.hadoop.util.ToolRunner; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class HBaseThriftTestingUtility { + + private static final Logger LOG = LoggerFactory.getLogger(HBaseThriftTestingUtility.class); + private Thread thriftServerOneThread; + private volatile Exception thriftServerOneException; + private ThriftServer thriftServer; + private int testServerPort; + + public int getServerPort() { + return testServerPort; + } + + public void startThriftServer(Configuration conf) throws Exception { + List<String> args = new ArrayList<>(); + testServerPort = HBaseTestingUtility.randomFreePort(); + args.add("-" + Constants.PORT_OPTION); + args.add(String.valueOf(testServerPort)); + thriftServer = new ThriftServer(conf); + LOG.info("Starting Thrift Server One on port: " + testServerPort); + + thriftServerOneException = null; + thriftServerOneThread = new Thread(() -> { + try { + thriftServer.run(args.toArray(new String[args.size()])); + } catch (Exception e) { + thriftServerOneException = e; + } + }); + thriftServerOneThread.setName(ThriftServer.class.getSimpleName() + "-one"); + thriftServerOneThread.start(); + + if (thriftServerOneException != null) { + LOG.error("HBase Thrift server threw an exception ", thriftServerOneException); + throw new Exception(thriftServerOneException); + } + + // wait up to 10s for the server to start + for (int i = 0; i < 100 Review comment: What if the server is not up in 10s? Looks like the loop breaks. Should we handle it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
