[ 
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978999#comment-16978999
 ] 

Viraj Jasani commented on HBASE-23279:
--------------------------------------

Facing some issue with one UT: TestGetClosestAtOrBefore.testUsingMetaAndBinary()

Here, we are writing rows for 3 tables: A, B, C. For each tables, we start 
writing rowkeys in some ranges in meta. e.g. first range is ('', key1) and 
second is (key2,key3) and so on. While flushing meta, the error is "key not 
lexically larger than previous" for second row. Without this patch(with NONE 
encoding), this test passes but with default encoding as ROW_INDEX_V1, not sure 
what is going wrong while comparing second row with first one.

Sample error: Current Cell is 2nd region of Table A and Last Cell is 1st region 
of Table A:
{code:java}
java.io.IOException: Added a key not lexically larger than previous. Current 
cell = 
A,\x00\x02,1574315191138.fce5ac5d556ff2c00d7c03a47ddd1270./info:regioninfo/1574315191138/Put/vlen=41/seqid=3/PBUF\x08\xE2\xD6\xFD\xE3\xE8-\x12\x0C\x0A\x07default\x12\x01A\x1A\x02\x00\x02"\x04\x00\x00\x00\x04(\x000\x008\x00,
 lastCell = 
A,,1574315191089.3745f86220ac4361440a77263915ca1a./info:regioninfo/1574315191089/Put/vlen=39/seqid=2/PBUF\x08\xB1\xD6\xFD\xE3\xE8-\x12\x0C\x0A\x07default\x12\x01A\x1A\x00"\x04\x00\x00\x00\x02(\x000\x008\x00{code}

> Switch default block encoding to ROW_INDEX_V1
> ---------------------------------------------
>
>                 Key: HBASE-23279
>                 URL: https://issues.apache.org/jira/browse/HBASE-23279
>             Project: HBase
>          Issue Type: Wish
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Lars Hofhansl
>            Assignee: Viraj Jasani
>            Priority: Minor
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HBASE-23279.master.000.patch, 
> HBASE-23279.master.001.patch, HBASE-23279.master.002.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles 
> are slightly larger about 3% or so). I think that would a better default than 
> NONE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to