[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979018#comment-16979018 ]
Viraj Jasani commented on HBASE-23279: -------------------------------------- The only change require in attached patch 003 is changing DataBlockEncoding: public static final DataBlockEncoding DEFAULT_DATA_BLOCK_ENCODING = DataBlockEncoding.ROW_INDEX_V1; With the patch applied, if I change above value to DataBlockEncoding.NONE, the test case passes, for DIFF, FAST_DIFF, it fails as per above comment > Switch default block encoding to ROW_INDEX_V1 > --------------------------------------------- > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish > Affects Versions: 3.0.0, 2.3.0 > Reporter: Lars Hofhansl > Assignee: Viraj Jasani > Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)