wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable
custom authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#discussion_r351848756
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
##########
@@ -391,7 +391,7 @@ private void handleSaslConnectionFailure(final int
currRetries, final int maxRet
user.doAs(new PrivilegedExceptionAction<Object>() {
@Override
public Object run() throws IOException, InterruptedException {
- if (shouldAuthenticateOverKrb()) {
+ if (provider.isKerberos()) {
Review comment:
nit: requires updating javadoc comment that still refers to removed _
shouldAuthenticateOverKrb()_ method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
