wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable
custom authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#discussion_r351846405
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java
##########
@@ -118,70 +118,22 @@ protected RpcConnection(Configuration conf,
HashedWheelTimer timeoutTimer, Conne
LOG.debug("RPC Server Kerberos principal name for service=" +
remoteId.getServiceName()
+ " is " + serverPrincipal);
}
Review comment:
This looks kerberos specific. If a pluggable new SASL authentication does
not care about server principals, it might not have it within the securityInfo
instance, so maybe we should add some
SaslClientAuthenticationProvider.validateSecurityInfo abstract method to be
called here, then real validation would be on each individual
SaslClientAuthenticationProvider implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
