wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r354849938
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/DefaultProviderSelector.java ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.security.provider; + +import java.util.Map; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.security.User; +import org.apache.hadoop.hbase.util.Pair; +import org.apache.hadoop.io.Text; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.token.Token; +import org.apache.hadoop.security.token.TokenIdentifier; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@InterfaceAudience.Private +public class DefaultProviderSelector implements AuthenticationProviderSelector { + private static final Logger LOG = LoggerFactory.getLogger(DefaultProviderSelector.class); + + Configuration conf; + SimpleSaslClientAuthenticationProvider simpleAuth = null; + GssSaslClientAuthenticationProvider krbAuth = null; + DigestSaslClientAuthenticationProvider digestAuth = null; + Map<Byte,SaslClientAuthenticationProvider> providers; + + @Override + public void configure(Configuration conf, Map<Byte,SaslClientAuthenticationProvider> providers) { + this.conf = conf; + this.providers = providers; + for (SaslClientAuthenticationProvider provider : providers.values()) { + if (provider instanceof SimpleSaslClientAuthenticationProvider) { + if (simpleAuth != null) { + LOG.warn("Ignoring duplicate SimpleSaslClientAuthenticationProvider: previous={}," Review comment: So we don't want to replace these `simpleAuth`, `krbAuth` or `digestAuth` attributes when those were already initialised previously, but we had replaced `this.providers` already. Maybe we should also keep original `this.providers` value? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
