busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366382230
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java ########## @@ -33,12 +33,16 @@ */ @InterfaceAudience.Public @InterfaceStability.Evolving -public class ByteRangeUtils { +public final class ByteRangeUtils { Review comment: this is a binary incompatible change and matters because ByteRangeUtils is IA.Public ref: JLS 13.4.2 "final classes" https://docs.oracle.com/javase/specs/jls/se13/html/jls-13.html#jls-13.4.2 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services