Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#issuecomment-574287986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 7m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 44s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 55s | branch-1 passed | | +1 :green_heart: | compile | 0m 30s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 0m 35s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 5m 0s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 0m 35s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 1m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 25s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 59s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 0m 34s | the patch passed | | +1 :green_heart: | checkstyle | 5m 27s | root: The patch generated 0 new + 25 unchanged - 16 fixed = 25 total (was 41) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 1s | The patch has 1 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 2m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 58s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 28s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 0m 36s | the patch passed with JDK v1.7.0_242 | | +0 :ok: | findbugs | 0m 14s | hbase-checkstyle has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 13s | hbase-checkstyle in the patch passed. | | +1 :green_heart: | unit | 2m 33s | hbase-common in the patch passed. | | +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 54m 15s | | | Reason | Tests | |-------:|:------| | XML | Parsing Error(s): | | | hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1034 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile | | uname | Linux cffb61f88762 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1034/out/precommit/personality/provided.sh | | git revision | branch-1 / b5d0da7 | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | xml | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/artifact/out/xml.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/testReport/ | | Max. process+thread count | 162 (vs. ulimit of 10000) | | modules | C: hbase-checkstyle hbase-common U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
