saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368323705
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java ########## @@ -361,7 +361,7 @@ static HFileBlock createFromBuff(ByteBuff buf, boolean usesHBaseChecksum, final // This constructor is called when we deserialize a block from cache and when we read a block in // from the fs. fileCache is null when deserialized from cache so need to make up one. HFileContextBuilder fileContextBuilder = - fileContext != null ? new HFileContextBuilder(fileContext) : new HFileContextBuilder(); + fileContext != null ? new HFileContextBuilder(fileContext): new HFileContextBuilder(); Review comment: I can set these back. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services