saintstack commented on a change in pull request #1069: HBASE-23708 Support 
metrics for region traffic
URL: https://github.com/apache/hbase/pull/1069#discussion_r368655470
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 ##########
 @@ -3699,9 +3682,11 @@ public void 
prepareMiniBatchOperations(MiniBatchOperationInProgress<Mutation> mi
         if (mutation instanceof Put) {
           HRegion.updateCellTimestamps(familyCellMaps[index].values(), byteTS);
           miniBatchOp.incrementNumOfPuts();
+          miniBatchOp.incrementBytesForPuts(mutation.heapSize());
 
 Review comment:
   We spend a lot of cpu counting currently. This adds to the counting load.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to