saintstack commented on a change in pull request #1069: HBASE-23708 Support
metrics for region traffic
URL: https://github.com/apache/hbase/pull/1069#discussion_r368655213
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -3699,9 +3682,11 @@ public void
prepareMiniBatchOperations(MiniBatchOperationInProgress<Mutation> mi
if (mutation instanceof Put) {
HRegion.updateCellTimestamps(familyCellMaps[index].values(), byteTS);
miniBatchOp.incrementNumOfPuts();
+ miniBatchOp.incrementBytesForPuts(mutation.heapSize());
Review comment:
Do we traverse any synchronize blocks here or update any volatiles? In other
words, wondering what the cost of these updates are.
We are also bulking up metrics w/ these added numbers... the metrics we send
the master on each report (every second or so).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
