[
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022629#comment-17022629
]
Viraj Jasani edited comment on HBASE-23279 at 1/24/20 1:18 AM:
---------------------------------------------------------------
{quote}Offset is not right? Is our. math off in the test or passing down the
ByteBuff? This code has been in place since 2015.
{quote}
I believe math in test might be causing this, copyFromBufferToArray() looks
good. But the test is doing quite well with NONE encoding.
{quote}It seems avg keyLen for NONE encoding is ~60 whereas for ROW_INDEX_V1 it
is 458752.
{quote}
{quote}This seems wrong but unrelated?
{quote}
Only due to this, test is passing 458752 length for ByteBuff array down to
copyFromBufferToArray() and it fails to load these many records from offset 8
(offset also seems good and after updating with 0 also, issue persists)
was (Author: vjasani):
{quote}Offset is not right? Is our. math off in the test or passing down the
ByteBuff? This code has been in place since 2015.
{quote}
I believe math in test might be causing this, copyFromBufferToArray() looks
good. But the test is doing quite well with NONE encoding.
{quote}This seems wrong but unrelated?
{quote}
Only due to this, test is passing 458752 length for ByteBuff array down to
copyFromBufferToArray() and it fails to load these many records from offset 8
(offset also seems good and after updating with 0 also, issue persists)
> Switch default block encoding to ROW_INDEX_V1
> ---------------------------------------------
>
> Key: HBASE-23279
> URL: https://issues.apache.org/jira/browse/HBASE-23279
> Project: HBase
> Issue Type: Wish
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Lars Hofhansl
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23279.master.000.patch,
> HBASE-23279.master.001.patch, HBASE-23279.master.002.patch,
> HBASE-23279.master.003.patch, HBASE-23279.master.004.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles
> are slightly larger about 3% or so). I think that would a better default than
> NONE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
