[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024179#comment-17024179 ]
ramkrishna.s.vasudevan edited comment on HBASE-23279 at 1/27/20 8:57 AM: ------------------------------------------------------------------------- The test case had to be changed to work with DBEs and to use the DBE's seeker. Currently it is not that way. Once we change it things will work. I was able to make it work after changing it. Not guaranteeing the size of the data block in this case - what problems do we have? the bucket cache will have lesser blocks cached? Should we find an average estimate of this row offset size while writing the meta data of file with Row_INDEX_V1? was (Author: ram_krish): The test case had to be changed to work with DBEs and to use the DBE's seeker. Currently it is not that way. Once we change it things will work. Not guaranteeing the size of the data block in this case - what problems do we have? the bucket cache will have lesser blocks cached? Should we find an average estimate of this row offset size while writing the meta data of file with Row_INDEX_V1? > Switch default block encoding to ROW_INDEX_V1 > --------------------------------------------- > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish > Affects Versions: 3.0.0, 2.3.0 > Reporter: Lars Hofhansl > Assignee: Viraj Jasani > Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch, > HBASE-23279.master.003.patch, HBASE-23279.master.004.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)