virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379769648
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2262,30 @@ boolean snapshotCleanupSwitch(final boolean on, final
boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+
+ /**
+ * Retrieves online slowlog responses from in memory ringbuffer maintained by
+ * RegionServers
+ *
+ * @param serverNames Server names to get slowlog responses from
+ * @param slowLogQueryFilter filter to be used if provided
+ * @return online slowlog response list
+ * @throws IOException if a remote or network exception occurs
+ */
+ List<SlowLogRecord> getSlowLogResponses(final List<ServerName> serverNames,
Review comment:
Actually, these names were different in my first patch, then I changed it
based on PR review and also based on suggestion on Jira(~4 months back), I
think more time was spent with this and now it feels like good to maintain
parity between shell command and Admin API naming. Hence, I don't feel
comfortable changing it now :)
Let me update JavaDocs accordingly and mention about slow RPC logs.
Hope it is fine with you @bharathv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
