virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379774633
##########
File path: hbase-common/src/main/resources/hbase-default.xml
##########
@@ -1956,4 +1956,27 @@ possible configurations would overwhelm and obscure the
important.
enable this feature.
</description>
</property>
+ <property>
+ <name>hbase.regionserver.slowlog.ringbuffer.size</name>
+ <value>256</value>
+ <description>
+ Default size of ringbuffer to be maintained by each RegionServer in order
+ to store online slowlog responses. This is an in-memory ring buffer of
+ requests that were judged to be too slow in addition to the
responseTooSlow
+ logging. The in-memory representation would be complete.
+ For more details, please look into Doc Section:
+ Get Slow Response Log from shell
+ </description>
+ </property>
+ <property>
+ <name>hbase.regionserver.slowlog.buffer.enabled</name>
Review comment:
On one hand I agree with this and this is something I have implemented in
past too but on the other hand, user would not want to change
`hbase.regionserver.slowlog.ringbuffer.size` that frequently. The default value
for the config is not too high, not too low either. Hence, the reason to have
enable/disable config is to ensure we provide reasonable default value to
ringbuffer size, something user doesn't have to spend much time with and let
user enable this config without touching ringbuffer size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
