huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#discussion_r404450094
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java ########## @@ -579,8 +579,8 @@ private void interruptOrAbortWhenFail(ReplicationQueueOperation op) { if (e.getCause() != null && e.getCause() instanceof KeeperException.SystemErrorException && e.getCause().getCause() != null && e.getCause() .getCause() instanceof InterruptedException) { - throw new RuntimeException( - "Thread is interrupted, the replication source may be terminated"); + LOG.info("Thread is interrupted, the replication source may be terminated"); + return; Review comment: I have manually tested the code path by injecting an InterruptException at zkwatcher and made sure thread exits and no region server abort. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services