Apache9 commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610109625 OK, skimmed HBASE-20561, the goal there was to avoid the region server to be aborted... I think the RuntimeException was used to skip all the following code and propagate it soon to the most top level of code, as the operation is failed, we should not execute the following code any more, a simple return will make the upper layer think the operation is succeeded, which is incorrect. Now the code at the top level will abort the region server? Maybe that's the place need to be fixed. If RuntimeException is too general, maybe we could introduce a special exception and throw it, and at some places we catch it and just ignore it and quit.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
