[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257796#comment-13257796 ]
jirapos...@reviews.apache.org commented on HBASE-5621: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4714/#review7046 ----------------------------------------------------------- security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java <https://reviews.apache.org/r/4714/#comment15632> There are a bunch of import changes here. Are they all needed? security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java <https://reviews.apache.org/r/4714/#comment15631> Why can we get away w/ removing the try/catch? Because the caller handles it? src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java <https://reviews.apache.org/r/4714/#comment15633> good src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <https://reviews.apache.org/r/4714/#comment15634> Does this belong in this patch? Is it part of another patch? src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <https://reviews.apache.org/r/4714/#comment15635> Yeah, this stuff is from another patch? Why you adding it? src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <https://reviews.apache.org/r/4714/#comment15636> Are these from Elliotts' patch? Maybe its reviewboard that is messing up? I'm only looking at diff between your v2 and v3 patch. - Michael On 2012-04-19 17:46:17, Jimmy Xiang wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4714/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-04-19 17:46:17) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. This is the admin part of HBase-5443. AdminProtocol part. bq. bq. bq. This addresses bug HBASE-5621. bq. https://issues.apache.org/jira/browse/HBASE-5621 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79 bq. src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72 bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9 bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50 bq. src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb bq. src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15 bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443 bq. src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8 bq. src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java d0570b9 bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 7239c5a bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe bq. src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865 bq. src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830 bq. src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3 bq. src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java ecaf9fe bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java e78e56d bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 61a5988 bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 759633d bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 7c59995 bq. src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 04fe8b6 bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2 bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c bq. src/main/protobuf/Admin.proto 132c5dd bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2 bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java 3cfc02b bq. src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 8af0f91 bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b bq. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de bq. src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java 301ee27 bq. src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152 bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 7ffd6bd bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15 bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java d0cad45 bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 6b64f10 bq. bq. Diff: https://reviews.apache.org/r/4714/diff bq. bq. bq. Testing bq. ------- bq. bq. All unit tests passed. bq. bq. bq. Thanks, bq. bq. Jimmy bq. bq. > Convert admin protocol of HRegionInterface to PB > ------------------------------------------------ > > Key: HBASE-5621 > URL: https://issues.apache.org/jira/browse/HBASE-5621 > Project: HBase > Issue Type: Sub-task > Components: ipc, master, migration, regionserver > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Fix For: 0.96.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira