[GitHub] [hbase] saintstack commented on a change in pull request #1478: HBASE-24137:The max merge count of metafixer should be configurable in MetaFixer

[GitBox]

saintstack commented on a change in pull request #1478: HBASE-24137:The max 
merge count of metafixer should be configurable in MetaFixer
URL: https://github.com/apache/hbase/pull/1478#discussion_r406603981
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
 ##########
 @@ -63,7 +61,7 @@
   MetaFixer(MasterServices masterServices) {
     this.masterServices = masterServices;
     this.maxMergeCount = this.masterServices.getConfiguration().
-        getInt(MAX_MERGE_COUNT_KEY, MAX_MERGE_COUNT_DEFAULT);
+        getInt("hbase.master.metafixer.max.merge.count", 10);
 
 Review comment:
   It was configurable before this change? You could add
   
     <property>
       <name>hbase.master.metafixer.max.merge.count</name>
       <value>11</value>
       <description>configure the max merge count</description>
     </property>
   
   ...
   to your hbase-site.xml and away you go?
   
   But maybe you think it deserves mention in the hbase-default.xml so 
operators can find it easier? If so, I'd suggest a fuller description.
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services