[GitHub] [hbase] virajjasani commented on a change in pull request #1478: HBASE-24137:The max merge count of metafixer should be configurable in MetaFixer

[GitBox]

virajjasani commented on a change in pull request #1478: HBASE-24137:The max 
merge count of metafixer should be configurable in MetaFixer
URL: https://github.com/apache/hbase/pull/1478#discussion_r406759145
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
 ##########
 @@ -63,7 +61,7 @@
   MetaFixer(MasterServices masterServices) {
     this.masterServices = masterServices;
     this.maxMergeCount = this.masterServices.getConfiguration().
-        getInt(MAX_MERGE_COUNT_KEY, MAX_MERGE_COUNT_DEFAULT);
+        getInt("hbase.master.metafixer.max.merge.count", 10);
 
 Review comment:
   Yes if the purpose is to mention this config in `hbase-default.xml`, good to 
also document it in `hbase-default.adoc` with detailed description.
   However, in that case, title of PR doesn't match. As @saintstack said, this 
is already configurable.
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services