joshelser commented on a change in pull request #1597:
URL: https://github.com/apache/hbase/pull/1597#discussion_r416151806
##########
File path: conf/hbase-site.xml
##########
@@ -21,4 +20,31 @@
*/
-->
<configuration>
+ <!--
+ The following properties are set for running HBase as a single process on a
+ developer workstation. With this configuration, HBase is running in
+ "stand-alone" mode and without a distributed file system. In this mode, and
+ without further configuration, HBase and ZooKeeper data are stored on the
+ local filesystem, in a path under the value configured for `hbase.tmp.dir`.
+ This value is overridden from its default value of `/tmp` because many
+ systems clean `/tmp` on a regular basis. Instead, it points to a path
within
+ this HBase installation directory.
+
+ Running against the `LocalFileSystem`, as opposed to a distributed
+ filesystem, runs the risk of data integrity issues and data loss. Normally
+ HBase will refuse to run in such an environment. Setting
+ `hbase.unsafe.stream.capability.enforce` to `false` overrides this
behavior,
+ permitting operation. This configuration is for the developer workstation
+ only and __should not be used in production!__
Review comment:
Is this copy of hbase-site.xml what makes it into the binary tarball? If
so, does that worry you at all?
I'm lamenting that we don't have a good way to differentiate a "user doing
things locally/in-situ" vs. "a user building out a real system". Eventually, we
can't stop someone from shooting themselves in the foot...
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -348,19 +350,11 @@ public static void setWALRootDir(final Configuration c,
final Path root) {
public static FileSystem getWALFileSystem(final Configuration c) throws
IOException {
Path p = getWALRootDir(c);
FileSystem fs = p.getFileSystem(c);
- // hadoop-core does fs caching, so need to propagate this if set
+ // hadoop-core does fs caching, so need to propogate this if set
Review comment:
This was actually correct the first time :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
