joshelser commented on a change in pull request #1597:
URL: https://github.com/apache/hbase/pull/1597#discussion_r416185036



##########
File path: conf/hbase-site.xml
##########
@@ -21,4 +20,31 @@
  */
 -->
 <configuration>
+  <!--
+    The following properties are set for running HBase as a single process on a
+    developer workstation. With this configuration, HBase is running in
+    "stand-alone" mode and without a distributed file system. In this mode, and
+    without further configuration, HBase and ZooKeeper data are stored on the
+    local filesystem, in a path under the value configured for `hbase.tmp.dir`.
+    This value is overridden from its default value of `/tmp` because many
+    systems clean `/tmp` on a regular basis. Instead, it points to a path 
within
+    this HBase installation directory.
+
+    Running against the `LocalFileSystem`, as opposed to a distributed
+    filesystem, runs the risk of data integrity issues and data loss. Normally
+    HBase will refuse to run in such an environment. Setting
+    `hbase.unsafe.stream.capability.enforce` to `false` overrides this 
behavior,
+    permitting operation. This configuration is for the developer workstation
+    only and __should not be used in production!__

Review comment:
       I'm just trying to think of ways that we can better prevent a user from 
doing themselves harm, and ways that people could fall into trouble if this is 
in the distribution's default configuration file. e.g. I could imagine a 
process which starts with hbase-site.xml from a release tarball, and then 
additions on top of that. This change would adversely affect them.
   
   The only other thing I could think of would be to carry 
`hbase.cluster.distributed=false` here to try to be more confident that they 
are actually changing the config, giving it some thought. I'm mostly just 
thinking out loud though. I'm not personally convinced that turning off the 
sync enforcement OOTB is "worrisome". 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to