markrmiller commented on a change in pull request #1659:
URL: https://github.com/apache/hbase/pull/1659#discussion_r420467085
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java
##########
@@ -187,11 +187,19 @@ public void startHBase() throws IOException {
}
public void startRegionServer(int port) {
- startServer(ServerType.RS, port);
+ try {
+ startServer(ServerType.RS, port);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
Review comment:
It just because the new impl for getting the port throws IOException -
it has to be caught and dealt with somewhere - until cleanup, it was here. I
put this up early since I saw the other issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
