markrmiller commented on a change in pull request #1659:
URL: https://github.com/apache/hbase/pull/1659#discussion_r420469084
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
##########
@@ -264,4 +265,34 @@ boolean deleteDir(final File dir) {
boolean failIfTimeout, Predicate<E> predicate) throws E {
return Waiter.waitFor(this.conf, timeout, interval, failIfTimeout,
predicate);
}
+
+ private static final PortAllocator portAllocator = new PortAllocator();
+
+ public static int randomFreePort() {
+ try {
+ return portAllocator.randomFreePort();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ static class PortAllocator {
+
+ public PortAllocator() {
+
+ }
+
+ public int randomFreePort() throws IOException {
+ ServerSocket s = new ServerSocket(0);
+ try {
+ s.setReuseAddress(true);
+ int port = s.getLocalPort();
+ return port;
+ } finally {
+ if (null != s) {
+ s.close();
+ }
+ }
+ }
+ }
}
Review comment:
Let me try and summarize that:
I think your patch attempts to solve the issue for this test in a solid way.
With my patch, I'm trying to climb into these getPort util methods and make
them more solid - though they cannot necessarily be made as solid.
So I don't think the two things are necessarily exclusive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
