[
https://issues.apache.org/jira/browse/HBASE-23832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102784#comment-17102784
]
Anoop Sam John commented on HBASE-23832:
----------------------------------------
[~busbey]
Ya there are 4 configs in the renamed list. 3 of them are completely removed
from referring in the code.
One is still used partially
{code}
public static final String HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND =
"hbase.hregion.percolumnfamilyflush.size.lower.bound";
public static final String HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND_MIN =
"hbase.hregion.percolumnfamilyflush.size.lower.bound.min";
...
long minimumLowerBound =
getConf().getLong(HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND_MIN,
DEFAULT_HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND_MIN);
if (minimumLowerBound > flushSizeLowerBound) {
flushSizeLowerBound = minimumLowerBound;
}
// use the setting in table description if any
String flushedSizeLowerBoundString =
region.getTableDescriptor().getValue(HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND);
if (flushedSizeLowerBoundString == null) {
LOG.debug("No {} set in table {} descriptor;"
+ "using region.getMemStoreFlushHeapSize/# of families ({}) "
+ "instead."
, HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND
, region.getTableDescriptor().getTableName()
, StringUtils.humanSize(flushSizeLowerBound)
+ ")");
} else {
try {
flushSizeLowerBound = Long.parseLong(flushedSizeLowerBoundString);
{code}
It is wrt the old config name used at the table definition level.
The compaction configs also can be tuned at table level. So whether we can
completely remove it I doubt ! Moreover we will just silently ignore it if we
remove the config from code.
> Old config hbase.hstore.compactionThreshold is ignored
> ------------------------------------------------------
>
> Key: HBASE-23832
> URL: https://issues.apache.org/jira/browse/HBASE-23832
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: Sambit Mohapatra
> Priority: Critical
>
> In 2.x we added new name 'hbase.hstore.compaction.min' for this. Still for
> compatibility we allow the old config name and honor that in code
> {code}
> minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY,
> /*old name*/ conf.getInt("hbase.hstore.compactionThreshold", 3)));
> {code}
> But if hbase.hstore.compactionThreshold alone is configured by user, there is
> no impact of that.
> This is because in hbase-default.xml we have the new config with a value of
> 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a
> value 3 even if it is not explicitly configured by customer and instead used
> the old key.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
