[
https://issues.apache.org/jira/browse/HBASE-23832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105636#comment-17105636
]
Anoop Sam John commented on HBASE-23832:
----------------------------------------
I will do one thing .. I will push this patch as such even to master also. Lets
open an umbrella Jira and have wider discussion for this and other configs
which are like deprecated through entire 2.x lifespan. If we remove those
completely from the code and if so what all we should do wrt BC .
These are configs which might be in existing table definition also. If so what
we should do. Whether we should have some migration steps and all. Lets discuss
those in a separate issue probably with a discussion at dev@.
> Old config hbase.hstore.compactionThreshold is ignored
> ------------------------------------------------------
>
> Key: HBASE-23832
> URL: https://issues.apache.org/jira/browse/HBASE-23832
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: Sambit Mohapatra
> Priority: Critical
>
> In 2.x we added new name 'hbase.hstore.compaction.min' for this. Still for
> compatibility we allow the old config name and honor that in code
> {code}
> minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY,
> /*old name*/ conf.getInt("hbase.hstore.compactionThreshold", 3)));
> {code}
> But if hbase.hstore.compactionThreshold alone is configured by user, there is
> no impact of that.
> This is because in hbase-default.xml we have the new config with a value of
> 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a
> value 3 even if it is not explicitly configured by customer and instead used
> the old key.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
