saintstack commented on a change in pull request #1418:
URL: https://github.com/apache/hbase/pull/1418#discussion_r426977238
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
##########
@@ -752,9 +785,17 @@ public static HRegionInfo convert(final
HBaseProtos.RegionInfo proto) {
// RegionInfo into HRegionInfo which is what is wanted here.
HRegionInfo hri;
if (ri.isMetaRegion()) {
- hri = ri.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID ?
+ //TODO francis room for streamlining this logic
+ hri = ri.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID &&
ri.getRegionId() == 1
Review comment:
What's the thinking here? Replicas for ROOT too?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/NotAllRootRegionsOnlineException.java
##########
@@ -25,19 +25,19 @@
* Thrown when an operation requires the root and all meta regions to be online
*/
@InterfaceAudience.Public
-public class NotAllMetaRegionsOnlineException extends DoNotRetryIOException {
+public class NotAllRootRegionsOnlineException extends DoNotRetryIOException {
Review comment:
How many ROOT regions? If one, shouldn't be plural? Or 'All'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
