saintstack commented on a change in pull request #1418:
URL: https://github.com/apache/hbase/pull/1418#discussion_r427718743
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/CatalogAccessor.java
##########
@@ -313,16 +330,31 @@ public static HRegionLocation
getRegionLocation(Connection connection, RegionInf
*/
public static Result getCatalogFamilyRow(Connection connection, RegionInfo
ri)
throws IOException {
- Get get = new Get(getMetaKeyForRegion(ri));
+ Get get = new Get(getCatalogKeyForRegion(ri));
Review comment:
Yeah, if you didn't change the name patch would be way smaller.
##########
File path: bin/region_status.rb
##########
@@ -53,7 +53,7 @@
java_import org.apache.hadoop.hbase.filter.FirstKeyOnlyFilter
java_import org.apache.hadoop.hbase.util.Bytes
java_import org.apache.hadoop.hbase.HRegionInfo
-java_import org.apache.hadoop.hbase.MetaTableAccessor
+java_import org.apache.hadoop.hbase.CatalogAccessor
Review comment:
Have to change name of this class? Would patch be smaller if no class
name change? (New name is better but high-cost changing it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
