Joseph295 commented on a change in pull request #1783:
URL: https://github.com/apache/hbase/pull/1783#discussion_r430934955



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -1769,7 +1771,7 @@ public void setTimeoutForWriteLock(long 
timeoutForWriteLock) {
           storeCloserThreadPool.shutdownNow();
         }
       }
-
+      storeFileOpenAndCloseThreadPool.shutdownNow();

Review comment:
       
   > This means keeping this 'storeFileOpenAndCloseThreadPool' active till the 
Region is closed.
   > previously we create the pool at the region open time and once the stores 
are opened, the pool is shutdown. Keeping it longer this way not looks good
   
   There is a timeout for this thread pool, after some time, the threads will 
be destroyed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to