anoopsjohn commented on a change in pull request #1783:
URL: https://github.com/apache/hbase/pull/1783#discussion_r431030552



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -1769,7 +1771,7 @@ public void setTimeoutForWriteLock(long 
timeoutForWriteLock) {
           storeCloserThreadPool.shutdownNow();
         }
       }
-
+      storeFileOpenAndCloseThreadPool.shutdownNow();

Review comment:
       The non core threads will get removed after the idle timeout.  But the 
way we create the pool, we pass the number of threads (as per the config) as 
the core threads count.
   But we set
   boundedCachedThreadPool.allowCoreThreadTimeOut(true)
   So this helps. I missed this part.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to