anoopsjohn commented on a change in pull request #1881: URL: https://github.com/apache/hbase/pull/1881#discussion_r438667037
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ########## @@ -622,7 +622,8 @@ void setDataBlockEncoderInTest(HFileDataBlockEncoder blockEncoder) { for (HStoreFile storeFile : results) { if (compactedStoreFiles.contains(storeFile.getPath().getName())) { LOG.warn("Clearing the compacted storefile {} from {}", storeFile, this); - storeFile.getReader().close(true); + storeFile.getReader().close(storeFile.getCacheConf() != null ? Review comment: Checking again.. Sorry my bad. I wanted to add this at other place but ended up here. This is a call happening during region open. So you might want to keep ur change here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org