anoopsjohn commented on a change in pull request #1881:
URL: https://github.com/apache/hbase/pull/1881#discussion_r438669342
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -2741,7 +2741,8 @@ private void removeCompactedfiles(Collection<HStoreFile>
compactedfiles)
LOG.trace("Closing and archiving the file {}", file);
// Copy the file size before closing the reader
final long length = r.length();
- r.close(true);
+ r.close(file.getCacheConf() != null ?
Review comment:
This area will be getting called when we close a store as well as when
the CompactionDischarger finds unreferenced compacted files..
CompactionDischarger is working in an async way anyways. But ya as per ur
explanation, during close() we wanted to keep it this was as in patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
