[ 
https://issues.apache.org/jira/browse/HBASE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264432#comment-13264432
 ] 

stack commented on HBASE-5806:
------------------------------

Chinna This is good work.  Can you provide more detail on the scenarios you are 
fixing?  I'm trying to make sure I understand.  For example, for #1 above, we 
are talking about the regionserver crashing somewhere here (from 
SplitTransaction):

{code}
    if (!testing) {
      
services.removeFromOnlineRegions(this.parent.getRegionInfo().getEncodedName());
    }
    this.journal.add(JournalEntry.OFFLINED_PARENT);
{code}

Is that right?

The patch seems reasonable.  Could we make a test at all?  There are some tests 
around splitting already w/ Mocks.  Could we add to these?

Good stuff.
                
> Handle split region related failures on master restart and RS restart
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5806
>                 URL: https://issues.apache.org/jira/browse/HBASE-5806
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Chinna Rao Lalam
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-5806.patch
>
>
> This issue is raised to solve issues that comes out of partial region split 
> happened and the region node in the ZK which is in RS_ZK_REGION_SPLITTING and 
> RS_ZK_REGION_SPLIT is not yet processed.
> This also tries to address HBASE-5615.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to