[ https://issues.apache.org/jira/browse/HBASE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269742#comment-13269742 ]
Zhihong Yu commented on HBASE-5806: ----------------------------------- Overall, patch looks good. {code} default: - throw new IllegalStateException("Received event is not valid."); + break; {code} Should the event be logged in the default case ? {code} + // If Znode not exists dont consider this region + if (data == null) { {code} 'not exists' -> 'does not exist' {code} + public static class MockedMaster extends HMaster { {code} I think the class should be private. A better name would be MockMasterWithoutCatalogJanitor. > Handle split region related failures on master restart and RS restart > --------------------------------------------------------------------- > > Key: HBASE-5806 > URL: https://issues.apache.org/jira/browse/HBASE-5806 > Project: HBase > Issue Type: Bug > Affects Versions: 0.92.1 > Reporter: ramkrishna.s.vasudevan > Assignee: Chinna Rao Lalam > Fix For: 0.92.2, 0.96.0, 0.94.1 > > Attachments: HBASE-5806.patch, HBASE-5806_0.94.patch, > HBASE-5806_trunk.patch > > > This issue is raised to solve issues that comes out of partial region split > happened and the region node in the ZK which is in RS_ZK_REGION_SPLITTING and > RS_ZK_REGION_SPLIT is not yet processed. > This also tries to address HBASE-5615. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira