busbey commented on a change in pull request #2174:
URL: https://github.com/apache/hbase/pull/2174#discussion_r462950123
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -793,8 +793,15 @@ public HRegion(final HRegionFileSystem fs, final WAL wal,
final Configuration co
throw new IllegalArgumentException(MEMSTORE_FLUSH_PER_CHANGES + " can
not exceed "
+ MAX_FLUSH_PER_CHANGES);
}
- this.rowLockWaitDuration = conf.getInt("hbase.rowlock.wait.duration",
- DEFAULT_ROWLOCK_WAIT_DURATION);
+ int tmpRowLockDuration = conf.getInt("hbase.rowlock.wait.duration",
+ DEFAULT_ROWLOCK_WAIT_DURATION);
+ if (tmpRowLockDuration <= 0) {
Review comment:
I dunno. If the reason we're treating it as 1ms, rather than e.g.
refusing to open the region, is because in old hbase versions you could rely on
this behavior then that's no less true in hbase 4 then in hbase 1.7.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
