busbey commented on a change in pull request #2174:
URL: https://github.com/apache/hbase/pull/2174#discussion_r462951045
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -793,8 +793,15 @@ public HRegion(final HRegionFileSystem fs, final WAL wal,
final Configuration co
throw new IllegalArgumentException(MEMSTORE_FLUSH_PER_CHANGES + " can
not exceed "
+ MAX_FLUSH_PER_CHANGES);
}
- this.rowLockWaitDuration = conf.getInt("hbase.rowlock.wait.duration",
- DEFAULT_ROWLOCK_WAIT_DURATION);
+ int tmpRowLockDuration = conf.getInt("hbase.rowlock.wait.duration",
+ DEFAULT_ROWLOCK_WAIT_DURATION);
+ if (tmpRowLockDuration <= 0) {
Review comment:
We could remove mention of the reasoning about old versions of hbase all
the time though and just say we are doing it since not doing so will mean the
region won't allow row locks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
