[ 
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176263#comment-17176263
 ] 

Francis Christopher Liu commented on HBASE-11288:
-------------------------------------------------

Hi [~zhangduo], there's a lot of code for a few reasons: 1. The way I wrote the 
patch was to be easy to read how adding root is merely piggybacking/extending 
on a lot of the meta code hence there's a lot of copy paste,  2. The code to 
split meta will be basically touching existing code that's been touched already 
but will be generalized. 3. There's already some code that went in to address 
splittable meta. 4. There's some refactoring (renaming root to meta), 
generalization, etc. The production could changes would mainly be generalizing 
and extending existing code paths. I could try and cleanup the branch-2 patch 
so we can see what it would look like if that's a big concern?

With regards to biasing root as a table. Root is half of the catalog it's 
responsibilities are sort of similar to that of the meta table hence I think 
there's some reasonable motivation with the bias. In which case I would like to 
understand why we are doing the specialized solution for root instead of coming 
up with a general one for the catalog as a whole? Also why is it worth it? 
Sorry if I sound like a broken record, I see that you responded to my question 
in a previous post. I just want to make sure I understand your current position 
(as some things might've changed these past 2 weeks)?




> Splittable Meta
> ---------------
>
>                 Key: HBASE-11288
>                 URL: https://issues.apache.org/jira/browse/HBASE-11288
>             Project: HBase
>          Issue Type: Umbrella
>          Components: meta
>            Reporter: Francis Christopher Liu
>            Assignee: Francis Christopher Liu
>            Priority: Major
>         Attachments: jstack20200807_bad_rpc_priority.txt, root_priority.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to