apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r471690236



##########
File path: 
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftAdmin.java
##########
@@ -1277,4 +1278,9 @@ public void updateRSGroupConfig(String groupName, 
Map<String, String> configurat
       throws IOException {
     throw new NotImplementedException("updateRSGroupConfig not supported in 
ThriftAdmin");
   }
+
+  @Override
+  public List<BalancerDecisionRecords> getBalancerDecisions() throws 
IOException {

Review comment:
       If we had one admin API for master and regionservers that returned 
protobuf encoded entries, then the thrift API could support it. First cut could 
just pass through the encoded PB. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to