apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r471701524
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java
##########
@@ -1057,4 +1057,9 @@ public void updateRSGroupConfig(String groupName,
Map<String, String> configurat
throws IOException {
get(admin.updateRSGroupConfig(groupName, configuration));
}
+
+ @Override
+ public List<BalancerDecisionRecords> getBalancerDecisions() throws
IOException {
Review comment:
I agree, that's the trade off here. Some pain now for flexibility later,
or not much pain and no flexibility now or later. New APIs for each new type.
Either decision is not wrong or right.
A benefit to API per ring type is pressure from API compat concerns and
method proliferation will put a lot of pressure on new potential use cases for
this mechanism, will set a really high bar. Maybe too high, hence my concerns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
