[ 
https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179658#comment-17179658
 ] 

Duo Zhang commented on HBASE-24898:
-----------------------------------

Then I think you could set the offpeak hour as 23 to 0? If you test the 
isOffPeakHour with 23, it will go to the last line, and the condition is

return 23 < 0 || 23 <= 23

I think it will return true? What is the problem?

> Can not set 23:00~24:00 as offpeak hour now
> -------------------------------------------
>
>                 Key: HBASE-24898
>                 URL: https://issues.apache.org/jira/browse/HBASE-24898
>             Project: HBase
>          Issue Type: Bug
>          Components: tooling
>            Reporter: Zheng Wang
>            Assignee: Zheng Wang
>            Priority: Major
>
> The valid number in OffPeakHours is 0-23, and the end hour not included, so 
> we can not set 23:00-24:00 as offpeak hour now.
> My proposal is just change the valid number from 0-23 to 0-24, then we can 
> easily apply this pr to all active branchs, and folks do not need to change 
> them configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to