[
https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179680#comment-17179680
]
Zheng Wang commented on HBASE-24898:
------------------------------------
{quote}Just use 0-0? And I think you could use n-n, where n is [0, 23]?
{quote}
0 <= targetHour && targetHour < 0? seems not make sense.
{quote}And what is the usage of setting all hours as off peak? Isn't it the
same with all hours as peak?
{quote}
Used in TestStochasticLoadBalancer.testMoveCostMultiplier, which should use a
lower multiplier in offpeak.
> Can not set 23:00~24:00 as offpeak hour now
> -------------------------------------------
>
> Key: HBASE-24898
> URL: https://issues.apache.org/jira/browse/HBASE-24898
> Project: HBase
> Issue Type: Bug
> Components: tooling
> Reporter: Zheng Wang
> Assignee: Zheng Wang
> Priority: Major
>
> The valid number in OffPeakHours is 0-23, and the end hour not included, so
> we can not set 23:00-24:00 as offpeak hour now.
> My proposal is just change the valid number from 0-23 to 0-24, then we can
> easily apply this pr to all active branchs, and folks do not need to change
> them configuration.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
