z3n3r commented on a change in pull request #2445:
URL: https://github.com/apache/hbase/pull/2445#discussion_r506775087
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java
##########
@@ -158,4 +174,14 @@ default int compareRows(ByteBuffer row, Cell cell) {
* Do not pollute with types other than BBKV if can be helped; the
Comparator will slow.
*/
Comparator getSimpleComparator();
+
+ static CellComparator getComparator(TableName tableName) {
+ if (tableName.equals(TableName.ROOT_TABLE_NAME)) {
+ return RootCellComparator.ROOT_COMPARATOR;
+ }
+ if (tableName.equals(TableName.META_TABLE_NAME)) {
+ return MetaCellComparator.META_COMPARATOR;
+ }
+ return CellComparatorImpl.COMPARATOR;
Review comment:
No that's just artifact from the PoC iteration will consolidate the
other one to use this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
