z3n3r commented on a change in pull request #2445:
URL: https://github.com/apache/hbase/pull/2445#discussion_r506776132



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -2986,6 +2988,7 @@ public GetMastersResponse getMasters(RpcController 
rpcController, GetMastersRequ
     return resp.build();
   }
 
+  //TODO francis this needs to be get RootLocation now?
   @Override
   public GetMetaRegionLocationsResponse getMetaRegionLocations(RpcController 
rpcController,

Review comment:
       Yeah I have. Looks like I need to having something like this for 
backward compatibility but I also need to have a getRootregionLocations() one. 
Should I just rename this and worry about re-adding the existing api for 
compatibility later? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to