[
https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231052#comment-17231052
]
Josh Elser commented on HBASE-25279:
------------------------------------
Yeah, I think you're right. I didn't go looking to see if it should've been
closed down. In general, having any non-daemon threads in HBase processes is a
smell (which is what caught my attention).
Looks like HMaster creates an ZKWatcher but doesn't close it. Sounds like
something else to follow-up on.
I'm not sure if we get into any troubles just marking this thread as daemon. I
would think not, it's just a smell to not be proactively closing stuff down
that we spawn :)
> Non-daemon thread in ZKWatcher
> ------------------------------
>
> Key: HBASE-25279
> URL: https://issues.apache.org/jira/browse/HBASE-25279
> Project: HBase
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 3.0.0-alpha-1
>
>
> ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons
> which will prevent clean shut downs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
