[ 
https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231063#comment-17231063
 ] 

Bharath Vissapragada commented on HBASE-25279:
----------------------------------------------

> I'm not sure if we get into any troubles just marking this thread as daemon. 
> I would think not, it's just a smell to not be proactively closing stuff down 
> that we spawn 

I think daemon threads are useful if they are okay to be terminated abruptly 
and if there is not much state associated with them to be cleaned up. In this 
case, these threads are tied to underlying ZK connections which must be cleaned 
up. So, I don't think thats the right solution. 

Are you able to repro this at will? If so I can take a look.

> Non-daemon thread in ZKWatcher
> ------------------------------
>
>                 Key: HBASE-25279
>                 URL: https://issues.apache.org/jira/browse/HBASE-25279
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 3.0.0-alpha-1
>
>
> ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons 
> which will prevent clean shut downs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to