virajjasani edited a comment on pull request #2674: URL: https://github.com/apache/hbase/pull/2674#issuecomment-730317424
> > @thangTang can you please also write a unit test with the same scenarios that you mentioned over Jira? i.e > > startRow="112", rowPrefixFilter "11" and Scan can contain "111". > > Although you commented, but having clear unit test will be really good reference. > > Thanks for identifying the issue. > > I'd like to, but should i write the UT in the patch? I think it would be failure and the CI -1. I didn't get why it would fail. What I mean to say is you can write unit test such that the condition you provided with "111" and "112" holds true. If you are worrying about CI giving -1 for tests which are not relevant to this PR, that's fine, you don't have to worry. As long as we are certain that CI gave -1 for something which is irrelevant to this PR's changes, we can merge the PR. Thanks @thangTang Please let me know if you still have doubts :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
