virajjasani commented on a change in pull request #2674:
URL: https://github.com/apache/hbase/pull/2674#discussion_r527669124
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
##########
@@ -447,7 +450,16 @@ public Scan withStopRow(byte[] stopRow, boolean inclusive)
{
* after this method will yield undefined results.</b></p>
* @param rowPrefix the prefix all rows must start with. (Set <i>null</i> to
remove the filter.)
* @return this
+ * @deprecated since 3.0.0. The scan result might be unexpected in some
cases.
+ * e.g. startRow : "112" and rowPrefixFilter : "11"
+ * The Result of this scan might contains : "111"
+ * This method implements the filter by setting startRow and stopRow,
+ * but does not take care of the scene where startRow has been set.
+ * Users can compose this logic externally through
+ * {@link ClientUtil#calculateTheClosestNextRowKeyForPrefix(byte[])},
+ * so there is no need to implement it inside.
Review comment:
I think we can remove just this statement:
```
* Users can compose this logic externally through
* {@link ClientUtil#calculateTheClosestNextRowKeyForPrefix(byte[])},
* so there is no need to implement it inside.
```
because `ClientUtil` is IA.Private, hence we should not recommend it in
Javadoc.
@huaxiangsun Thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
