[ https://issues.apache.org/jira/browse/HBASE-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281502#comment-13281502 ]
Hadoop QA commented on HBASE-6059: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528713/HBASE-6059v5.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 34 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.replication.TestMultiSlaveReplication org.apache.hadoop.hbase.replication.TestMasterReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1963//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1963//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1963//console This message is automatically generated. > Replaying recovered edits would make deleted data exist again > ------------------------------------------------------------- > > Key: HBASE-6059 > URL: https://issues.apache.org/jira/browse/HBASE-6059 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: chunhui shen > Assignee: chunhui shen > Attachments: HBASE-6059-testcase.patch, HBASE-6059.patch, > HBASE-6059v2.patch, HBASE-6059v3.patch, HBASE-6059v4.patch, HBASE-6059v5.patch > > > When we replay recovered edits, we used the minSeqId of Store, It may cause > deleted data appeared again. > Let's see how it happens. Suppose the region with two families(cf1,cf2) > 1.put one data to the region (put r1,cf1:q1,v1) > 2.move the region from server A to server B. > 3.delete the data put by step 1(delete r1) > 4.flush this region. > 5.make major compaction for this region > 6.move the region from server B to server A. > 7.Abort server A > 8.After the region is online, we could get the deleted data(r1,cf1:q1,v1) > (When we replay recovered edits, we used the minSeqId of Store, because cf2 > has no store files, so its seqId is 0, so the edit log of put data will be > replayed to the region) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira