apurtell edited a comment on pull request #3691: URL: https://github.com/apache/hbase/pull/3691#issuecomment-931517322
@virajjasani > > Unlike the other two wrapper implementations (for aircompressor and lz4) this one is slightly different because the Snappy API doesn't adjust the output buffer position like the others do. > Even Zstd belongs to the same category as Snappy with this regard? zstd-jni adjusts the buffer position, so it's not like xerial snappy, but unlike the Snappy method, which returns void, the Zstd method returns as int the number of emitted bytes. We can use that directly rather than learn the same from looking at how the output buffer position advanced (although we could look at the position instead) The codec API contracts are all slightly different, but at least the same integration model of ByteBuffers works in all cases, so the implementations have the same general shape. There also isn't much there, really, just standard bytebuffer manipulations... clear, get, put, flip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
