Apache-HBase commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-932145184


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   3m 57s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 51s |  master passed  |
   | +1 :green_heart: |  compile  |   9m 24s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 11s |  master passed  |
   | +1 :green_heart: |  spotbugs  |  14m 19s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |   9m 15s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   1m 59s |  root: The patch generated 55 new 
+ 156 unchanged - 15 fixed = 211 total (was 171)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m 11s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  hadoopcheck  |  20m 25s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | -1 :x: |  spotbugs  |  10m 17s |  root generated 10 new + 0 unchanged - 0 
fixed = 10 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   2m 39s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 102m 46s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:root |
   |  |  
org.apache.hadoop.hbase.io.compress.aircompressor.HadoopCompressor.finalize() 
is public; should be protected  At HadoopCompressor.java:protected  At 
HadoopCompressor.java:[lines 56-58] |
   |  |  
org.apache.hadoop.hbase.io.compress.aircompressor.HadoopDecompressor.finalize() 
is public; should be protected  At HadoopDecompressor.java:protected  At 
HadoopDecompressor.java:[lines 53-55] |
   |  |  org.apache.hadoop.hbase.io.compress.lz4.Lz4Compressor.finalize() is 
public; should be protected  At Lz4Compressor.java:protected  At 
Lz4Compressor.java:[lines 57-59] |
   |  |  org.apache.hadoop.hbase.io.compress.lz4.Lz4Decompressor.finalize() is 
public; should be protected  At Lz4Decompressor.java:protected  At 
Lz4Decompressor.java:[lines 55-57] |
   |  |  org.apache.hadoop.hbase.io.compress.xerial.SnappyCompressor.finalize() 
is public; should be protected  At SnappyCompressor.java:protected  At 
SnappyCompressor.java:[lines 53-55] |
   |  |  
org.apache.hadoop.hbase.io.compress.xerial.SnappyDecompressor.finalize() is 
public; should be protected  At SnappyDecompressor.java:protected  At 
SnappyDecompressor.java:[lines 50-52] |
   |  |  org.apache.hadoop.hbase.io.compress.xz.LzmaCompressor.finalize() is 
public; should be protected  At LzmaCompressor.java:protected  At 
LzmaCompressor.java:[lines 97-99] |
   |  |  org.apache.hadoop.hbase.io.compress.xz.LzmaDecompressor.finalize() is 
public; should be protected  At LzmaDecompressor.java:protected  At 
LzmaDecompressor.java:[lines 83-85] |
   |  |  org.apache.hadoop.hbase.io.compress.zstd.ZstdCompressor.finalize() is 
public; should be protected  At ZstdCompressor.java:protected  At 
ZstdCompressor.java:[lines 55-57] |
   |  |  org.apache.hadoop.hbase.io.compress.zstd.ZstdDecompressor.finalize() 
is public; should be protected  At ZstdDecompressor.java:protected  At 
ZstdDecompressor.java:[lines 51-53] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3691/16/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3691 |
   | Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs 
hbaseanti checkstyle |
   | uname | Linux 1e00d4e55e98 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 121bdea230 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3691/16/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3691/16/artifact/yetus-general-check/output/new-spotbugs-root.html
 |
   | Max. process+thread count | 141 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-resource-bundle hbase-server 
hbase-mapreduce hbase-compression 
hbase-compression/hbase-compression-aircompressor 
hbase-compression/hbase-compression-lz4 
hbase-compression/hbase-compression-snappy 
hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd 
hbase-assembly . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3691/16/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to